Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting params in main.nf #2838

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Linting params in main.nf #2838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8824d23
Only match assignments of params
asp8200 Mar 11, 2024
2e1c818
Update changelog
asp8200 Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@

### Linting

- Only match assignments of params in `main.nf` and not references like `params.aligner == <something>` ([#2833](https://github.com/nf-core/tools/pull/2833))

### Components

### General
Expand Down
2 changes: 1 addition & 1 deletion nf_core/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ def fetch_wf_config(wf_path, cache_config=True):
main_nf = os.path.join(wf_path, "main.nf")
with open(main_nf) as fh:
for line in fh:
match = re.match(r"^\s*(params\.[a-zA-Z0-9_]+)\s*=", line)
match = re.match(r"^\s*(params\.[a-zA-Z0-9_]+)\s*=(?!=)", line)
if match:
config[match.group(1)] = "null"
except FileNotFoundError as e:
Expand Down
Loading