-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mtbseq workflow #8
Conversation
|
@Mxrcon the major problem here is related to In the plugin_includes - Found a nf-validation plugin import in ome/runner/work/tbanalyzer/tbanalyzer/workflows/mtbseqnf.nf, but nf-schema was used in nextflow.config |
…he new nf-core template
Hmm, just checked it, the port from |
Update after TestsHey, I've performed local tests for the latest commits and here are the outputs: Command executed:
Command Executed:
Hope that this is enough for a merge, a I would like to proceed with pipeline documentation in another PR if possible. @abhi18av, I would like to request a new review on this code before our next sync meet. Kindly, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Mxrcon , thank you for accommodating the change request and also for the end-to-end test for the MTBseq mode
. I am going ahead with the merge and then we can focus on local MAGMA
modules.
I have just tried to change the |
MTBseq addition
Hey there 👋,
This PR adds
mtbseq_nf
the module structure follows:
I kindly request for your review @abhi18av and @ycode-sh for proceeding with this work.
PR checklist
docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).