Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to unused "skip_sample_count" value in email templates #1459

Merged
merged 3 commits into from
Dec 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ Special thanks to the following for their contributions to the release:
- [PR #1463](https://github.com/nf-core/rnaseq/pull/1463) - Move channel operations outside of the onComplete() block
- [PR #1467](https://github.com/nf-core/rnaseq/pull/1467) - Add test suite for UMI handling functionality
- [PR #1466](https://github.com/nf-core/rnaseq/pull/1466) - Factor out UMI handling
- [PR #1459](https://github.com/nf-core/rnaseq/pull/1466) - Remove reference to unused "skip_sample_count" value in email templates

### Software dependencies

Expand Down
19 changes: 0 additions & 19 deletions assets/email_template.html
Original file line number Diff line number Diff line change
Expand Up @@ -34,25 +34,6 @@ <h4 style="margin-top: 0; color: inherit">nf-core/rnaseq execution completed uns
<p>The full error message was:</p>
<pre style="white-space: pre-wrap; overflow: visible; margin-bottom: 0">${errorReport}</pre>
</div>
""" } else if(skip_sample_count > 0) { out << """
<div
style="
color: #856404;
background-color: #fff3cd;
border-color: #ffeeba;
padding: 15px;
margin-bottom: 20px;
border: 1px solid transparent;
border-radius: 4px;
"
>
<h4 style="margin-top: 0; color: inherit">nf-core/rnaseq execution completed with warnings!</h4>
<p>
The pipeline finished successfully, but samples were skipped. Please check warnings at the top of the MultiQC report.
</p>
<p></p>
</div>

""" } else { out << """
<div
style="
Expand Down
7 changes: 0 additions & 7 deletions assets/email_template.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,6 @@ The full error message was:

${errorReport}
"""
} else if (skip_sample_count > 0) {
out << """##################################################
## nf-core/rnaseq execution completed with warnings ##
##################################################
The pipeline finished successfully, but samples were skipped.
Please check warnings at the top of the MultiQC report.
"""
} else {
out << "## nf-core/rnaseq execution completed successfully! ##"
}
Expand Down
Loading