-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First release PR (version bumped to 1.0.0) #25
Conversation
Createtsv tests
Chunking clusters
…a tags updated to chunk level
…r post-processing
exporting reps to fams mapping and fasta
… optional directory parameters added to output.md
…sholds changed to 0.97
Review points from James
first release version bump (1.0.0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last couple of very minor comments on the pseudo PR but all my points addressed, this is good to go!
I just noticed GitHub ACtions were entirely deactivated on this repository!?!?! I've activated them now, and I have triggered an AWS full test to double check this is working |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK the AWS test failed:
https://cloud.seqera.io/orgs/nf-core/workspaces/AWSmegatests/watch/BIbANt3VdGPQX
Error executing process > 'NFCORE_PROTEINFAMILIES:PROTEINFAMILIES:UPDATE_FAMILIES:CAT_HMM (mgnifams_update)'
Caused by:
Cannot invoke method lastIndexOf() on null object -- Check script '.nextflow/assets/nf-core/proteinfamilies/./workflows/../subworkflows/local/remove_redundancy/../../../modules/nf-core/cat/cat/main.nf' at line: 77
Source block:
def args = task.ext.args ?: ''
def args2 = task.ext.args2 ?: ''
def file_list = files_in.collect { it.toString() }
prefix = task.ext.prefix ?: "${meta.id}${getFileSuffix(file_list[0])}"
out_zip = prefix.endsWith('.gz')
in_zip = file_list[0].endsWith('.gz')
command1 = (in_zip && !out_zip) ? 'zcat' : 'cat'
command2 = (!in_zip && out_zip) ? "| pigz -c -p $task.cpus $args2" : ''
if(file_list.contains(prefix.trim())) {
error "The name of the input file can't be the same as for the output prefix in the " +
"module CAT_CAT (currently `$prefix`). Please choose a different one."
}
"""
$command1 \\
$args \\
${file_list.join(' ')} \\
$command2 \\
> ${prefix}
cat <<-END_VERSIONS > versions.yml
"${task.process}":
pigz: \$( pigz --version 2>&1 | sed 's/pigz //g' )
END_VERSIONS
"""
Container:
wave.seqera.io/wt/2c9d512a8942/biocontainers/pigz:2.3.4
Tip: you can replicate the issue by changing to the process work dir and entering the command `bash .command.run`
@nf-core-bot fix linting |
Co-authored-by: James A. Fellows Yates <[email protected]>
Co-authored-by: James A. Fellows Yates <[email protected]>
minor typo fix
folder.toUriString()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PR checklist
nf-core pipelines lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).