Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pb fq2bam #7357

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Update pb fq2bam #7357

wants to merge 8 commits into from

Conversation

gburnett-nvidia
Copy link
Contributor

@gburnett-nvidia gburnett-nvidia commented Jan 23, 2025

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@gburnett-nvidia
Copy link
Contributor Author

This PR includes testing for fastq merging, as well as changes to the input and output spec @blajoie

@blajoie
Copy link

blajoie commented Jan 23, 2025

Please let us know if any changes are needed to the inputs/outputs, we did implement a small refactor there with a goal of simplifying things. Would also appreciate a look at how we handled multiple input fastq pairs and keeping the RGs organized.

A separate PR for parabricks/deepvariant is coming ~tomorrow.

cc @gburnett-nvidia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants