Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use channel empty when no phix reference supplied because skipping #749

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Use channel empty when no phix reference supplied because skipping #749

merged 1 commit into from
Jan 21, 2025

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jan 21, 2025 •
edited
Loading

close #740

(fix from #718, but doing it in separate bug fix PR for a faster patch release)

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 requested a review from muabnezor January 21, 2025 10:48
@nf-core-bot
Copy link
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.1.1.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 64a13ef

+| ✅ 327 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Remove this line if you don't need a FASTA file [TODO: try and test using for --host_fasta and --host_genome]
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.1.1
  • Run at 2025-01-21 10:49:23

@jfy133
Copy link
Member Author

jfy133 commented Jan 21, 2025

The latest-everyhing failure is expected (see #pipeline-maintainers on slack)

@jfy133 jfy133 merged commit 5f460b8 into dev Jan 21, 2025
14 of 16 checks passed
@jfy133 jfy133 deleted the phix-fix branch January 21, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sateeshperi sateeshperi sateeshperi approved these changes

@muabnezor muabnezor Awaiting requested review from muabnezor

@Pranjal-Bioinfo Pranjal-Bioinfo Awaiting requested review from Pranjal-Bioinfo

@dialvarezs dialvarezs Awaiting requested review from dialvarezs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jfy133 @nf-core-bot @sateeshperi