Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate subworkflows into pipeline #431

Open
wants to merge 31 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
a64d4d7
Squashed commit of the following:
suzannejin Jan 27, 2025
4ae7888
Revert squashed commit of dev-ratio to updated dev code.
suzannejin Jan 27, 2025
b68f1e1
installed subworkflows and associated modules
suzannejin Jan 27, 2025
e38ad36
update modules
suzannejin Jan 27, 2025
9cbe267
update workflow to use the updated modules. It runs through test prof…
suzannejin Jan 27, 2025
3ee143c
[abundance_differential_filter] separate channels for rlog and vst
suzannejin Jan 29, 2025
9bd6518
[subworkflows] remove mergeMaps. Otherwise the contrastid_expid forma…
suzannejin Jan 29, 2025
dc74b0f
update modules.config
suzannejin Jan 29, 2025
5844aea
[workflow] a first version that calls the subworkflows and properly r…
suzannejin Jan 29, 2025
84484a2
fix pre-commit
suzannejin Jan 29, 2025
1830f1f
[module] revert gsea seed to its previous behaviour. This will pass t…
suzannejin Jan 29, 2025
7d3bfbe
update test.snap
suzannejin Jan 29, 2025
b4d5630
[workflow] set ch_gene_sets and ch_background to Channel.of([[]]) whe…
suzannejin Jan 29, 2025
83ebd1f
[pipeline] update modules.config to add LIMMA_NORM config, when using…
suzannejin Jan 30, 2025
62ad126
update test_rnaseq_limma snapshot
suzannejin Jan 30, 2025
5fd7781
merge from dev - after new yaml contrast logic is introduced
suzannejin Jan 30, 2025
fac8a3d
[bug] update workflow to properly handle ch_norm
suzannejin Jan 30, 2025
a90148d
update test snapshots
suzannejin Jan 30, 2025
63bb650
[test] update test snapshots - from singularity to docker
suzannejin Jan 30, 2025
692da91
Merge pull request #430 from suzannejin/dev-ratio-new
suzannejin Jan 30, 2025
b96540f
[modules] revert deseq2 modules into the version originally installed…
suzannejin Jan 31, 2025
de82c13
[feature] update differential subworkflow and pipeline for a common v…
suzannejin Jan 31, 2025
4f039eb
update changelog
suzannejin Jan 31, 2025
2b03659
remove subset option from LIMMA_NORM and DESEQ2_NORM
suzannejin Feb 4, 2025
2aefd3a
change(differentialabundance): simplify tools_differential and tools_…
suzannejin Feb 4, 2025
022a8ea
change(differentialabundance): use map criterias instead of meta meth…
suzannejin Feb 4, 2025
e6d3941
change(abundance_differential_filter): use groupTuple for ch_variance…
suzannejin Feb 4, 2025
a7d0357
change(subworkflows and report): revert to mergeMaps in differential …
suzannejin Feb 4, 2025
278b88f
change(tests): ignore pngs from test snapshotting
suzannejin Feb 4, 2025
80bda7b
fix(tests): remove unstable files from affy test snapshots
suzannejin Feb 4, 2025
8ad04de
fix(tests): remove redundant ignore png
suzannejin Feb 4, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Added

- [[#431](https://github.com/nf-core/differentialabundance/pull/431)] - Add differential and functional subworkflows. ([@suzannejin](https://github.com/suzannejin), co-authored by [@bjlang](https://github.com/bjlang) and [@caraiz2001](https://github.com/caraiz2001), review by [@pinin4fjords](https://github.com/pinin4fjords))
- [[#421](https://github.com/nf-core/differentialabundance/pull/421)] - Add immunedeconv module ([@nschcolnicov](https://github.com/nschcolnicov), review by [@pinin4fjords](https://github.com/pinin4fjords))
- [[#380](https://github.com/nf-core/differentialabundance/pull/380)] - Replace local filter_diff_table module with nf-core one, and create nf-tests for tabular_to_gsea_chip. ([@nschcolnicov](https://github.com/nschcolnicov), review by [@pinin4fjords](https://github.com/pinin4fjords))
- [[#358](https://github.com/nf-core/differentialabundance/pull/358)] - Added software version check in nf-tests and gene biotype column check in `.Rmd` ([@atrigila](https://github.com/atrigila), review by [@pinin4fjords](https://github.com/pinin4fjords))
Expand All @@ -32,6 +33,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- [[#431](https://github.com/nf-core/differentialabundance/pull/431)] - Replace the calls to differential and functional analysis modules by subworkflows. ([@suzannejin](https://github.com/suzannejin), review by [@pinin4fjords](https://github.com/pinin4fjords))
- [[#410](https://github.com/nf-core/differentialabundance/pull/410)] - Update contrasts file format to allow yaml ([@nschcolnicov](https://github.com/nschcolnicov), review by [@pinin4fjords](https://github.com/pinin4fjords)).
- [[#374](https://github.com/nf-core/differentialabundance/pull/374)] - Update all modules and subworkflows ([@nschcolnicov](https://github.com/nschcolnicov), review by [@pinin4fjords](https://github.com/pinin4fjords)).
- [[#348](https://github.com/nf-core/differentialabundance/pull/348)] - Update test_full profile matrix file and indentation of profiles in nextflow.config ([@nschcolnicov](https://github.com/nschcolnicov), review by [@WackerO](https://github.com/WackerO) and [@pinin4fjords](https://github.com/pinin4fjords))
Expand Down
36 changes: 34 additions & 2 deletions conf/modules.config
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ process {
"--shrink_lfc $params.deseq2_shrink_lfc",
"--cores $params.deseq2_cores",
"--subset_to_contrast_samples $params.differential_subset_to_contrast_samples",
((meta.blocking == null) ? '' : "--blocking_variables $meta.blocking"),
((meta.blocking == null) ? '' : "--blocking_variables $meta.blocking"), // TODO check what is the impact of blocking for NORM
].join(' ').trim() }
}

Expand Down Expand Up @@ -238,6 +238,38 @@ process {
].join(' ').trim() }
}

withName: LIMMA_NORM {
ext.prefix = 'all'
publishDir = [
[
path: { "${params.outdir}/tables/processed_abundance" },
mode: params.publish_dir_mode,
pattern: '*.{normalised_counts}.tsv'
],
]
ext.when = params.limma_use_voom
ext.args = { [
"--probe_id_col \"${params.features_id_col}\"",
"--sample_id_col \"${params.observations_id_col}\"",
"--ndups \"${params.limma_ndups}\"",
"--spacing \"${params.limma_spacing}\"",
"--block \"${params.limma_block}\"",
"--correlation ${params.limma_correlation}",
"--method \"${params.limma_method}\"",
"--proportion ${params.limma_proportion}",
"--stdev.coef.lim \"${params.limma_stdev_coef_lim}\"",
"--trend ${params.limma_trend}",
"--robust ${params.limma_robust}",
"--winsor.tail.p \"${params.limma_winsor_tail_p}\"",
"--p.value ${params.limma_p_value}",
"--lfc ${params.limma_lfc}",
"--confint ${params.limma_confint}",
"--subset_to_contrast_samples $params.differential_subset_to_contrast_samples",
suzannejin marked this conversation as resolved.
Show resolved Hide resolved
"--use_voom \"${params.limma_use_voom}\"",
((meta.blocking == null) ? '' : "--blocking_variables $meta.blocking"),
].join(' ').trim() }
}

withName: LIMMA_DIFFERENTIAL {
ext.prefix = { "${meta.id}" }
publishDir = [
Expand Down Expand Up @@ -494,7 +526,7 @@ process {
]
}

withName: 'TABULAR_TO_GSEA_CHIP' {
withName: 'CUSTOM_TABULARTOGSEACHIP' {
suzannejin marked this conversation as resolved.
Show resolved Hide resolved
publishDir = [
enabled: false
]
Expand Down
49 changes: 37 additions & 12 deletions modules.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,23 +17,28 @@
},
"custom/filterdifferentialtable": {
"branch": "master",
"git_sha": "833a65446ea117d092d4940f098236b6766e7aac",
"installed_by": ["modules"]
"git_sha": "045f0fbb65edaff2ca5002754dfa767d93551c66",
"installed_by": ["abundance_differential_filter", "modules"]
},
"custom/matrixfilter": {
"branch": "master",
"git_sha": "666652151335353eef2fcd58880bcef5bc2928e1",
"installed_by": ["modules"]
},
"custom/tabulartogseachip": {
"branch": "master",
"git_sha": "7900e49fb84969a2479ecfbeef7bcbe296513c90",
"installed_by": ["differential_functional_enrichment"]
},
"custom/tabulartogseacls": {
"branch": "master",
"git_sha": "666652151335353eef2fcd58880bcef5bc2928e1",
"installed_by": ["modules"]
"git_sha": "c835e1647a2e16237ae9d1db3d27351297f290c5",
"installed_by": ["differential_functional_enrichment", "modules"]
},
"custom/tabulartogseagct": {
"branch": "master",
"git_sha": "666652151335353eef2fcd58880bcef5bc2928e1",
"installed_by": ["modules"]
"git_sha": "c835e1647a2e16237ae9d1db3d27351297f290c5",
"installed_by": ["differential_functional_enrichment", "modules"]
},
"deseq2/differential": {
"branch": "master",
Expand All @@ -47,13 +52,13 @@
},
"gprofiler2/gost": {
"branch": "master",
"git_sha": "666652151335353eef2fcd58880bcef5bc2928e1",
"installed_by": ["modules"]
"git_sha": "6506b7bc2a369f0c21dc4fbc5e8d2af6c3e1a90b",
"installed_by": ["differential_functional_enrichment", "modules"]
},
"gsea/gsea": {
"branch": "master",
"git_sha": "666652151335353eef2fcd58880bcef5bc2928e1",
"installed_by": ["modules"]
"git_sha": "6506b7bc2a369f0c21dc4fbc5e8d2af6c3e1a90b",
"installed_by": ["differential_functional_enrichment", "modules"]
},
"gunzip": {
"branch": "master",
Expand All @@ -67,8 +72,18 @@
},
"limma/differential": {
"branch": "master",
"git_sha": "136f443c0a6d5c526410c7c9b73ce51ef457c341",
"installed_by": ["modules"]
"git_sha": "784b3a38aeafe9bb7e38f1369704dd5e6bcaf9f0",
"installed_by": ["abundance_differential_filter", "modules"]
},
"propr/grea": {
"branch": "master",
"git_sha": "138b2c45dde12b2075d6fe15a5d374b48d166d4a",
"installed_by": ["differential_functional_enrichment"]
},
"propr/propd": {
"branch": "master",
"git_sha": "0e9cb409c32d3ec4f0d3804588e4778971c09b7e",
"installed_by": ["abundance_differential_filter"]
},
"proteus/readproteingroups": {
"branch": "master",
Expand Down Expand Up @@ -114,6 +129,16 @@
},
"subworkflows": {
"nf-core": {
"abundance_differential_filter": {
"branch": "master",
"git_sha": "2b977a47af8a319f6ef6e7b918e7bb64babbaa04",
"installed_by": ["subworkflows"]
},
"differential_functional_enrichment": {
"branch": "master",
"git_sha": "6506b7bc2a369f0c21dc4fbc5e8d2af6c3e1a90b",
"installed_by": ["subworkflows"]
},
"utils_nextflow_pipeline": {
"branch": "master",
"git_sha": "c2b22d85f30a706a3073387f30380704fcae013b",
Expand Down
54 changes: 0 additions & 54 deletions modules/local/tabulartogseachip/main.nf

This file was deleted.

41 changes: 0 additions & 41 deletions modules/local/tabulartogseachip/meta.yml

This file was deleted.

49 changes: 0 additions & 49 deletions modules/local/tabulartogseachip/tests/main.nf.test

This file was deleted.

48 changes: 0 additions & 48 deletions modules/local/tabulartogseachip/tests/main.nf.test.snap

This file was deleted.

Loading
Loading