fix: dashboard 404 #948
Closed
fix: dashboard 404 #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/dashboard 原本就不是个 folder，可以后端做个跳转，搞这么复杂就远了 |
|
@naiba /dashboard/service 这种也会404，fix的时候记得cover 下 |
|
欢迎pr
…On Sun, Jan 5, 2025 at 15:38 quanljh ***@***.***> wrote:
@naiba <https://github.com/naiba> /dashboard/service
这种也会404，fix的时候记得cover 下
—
Reply to this email directly, view it on GitHub
<#948 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AG7DUMN5Z6KLLGBDX23NKED2JDOPTAVCNFSM6AAAAABUT3K4D2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZRGUZTGMJWHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is a bug where the dashboard page returns a 404 error.
In order to return 404 https status code when the path is not defined in frontend router, we can fallback all request to frontend but add a /404 path to return 404 status code. And in frontend, we redirect all undefined paths to /404 on not-found page.
Related frontend PRs:
hamster1963/nezha-dash-v1#26
nezhahq/admin-frontend#92
Tested in my server
Dashboard 200 OK
Dashboard 404
User page 404
