fix: Avoid pushing empty messages #6937
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found in sentry
Fixes a regular js console error when using notify_push where the awareness message may be pushed as empty string.
We avoid this filtering on the backend before we emit the messages over notify_push, but @max-nextcloud do you happen to know if seeing those empty awareness messages being pushed is expected?
Without this PR parsing the empty data fails in
text/src/services/y-websocket.js
Line 167 in ed57736