Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid pushing empty messages #6937

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Mar 10, 2025

Found in sentry
Fixes a regular js console error when using notify_push where the awareness message may be pushed as empty string.

We avoid this filtering on the backend before we emit the messages over notify_push, but @max-nextcloud do you happen to know if seeing those empty awareness messages being pushed is expected?

Screenshot 2025-03-10 at 12 58 08 Screenshot 2025-03-10 at 12 58 43

Without this PR parsing the empty data fails in

const encoder = readMessage(provider, new Uint8Array(event.data), true)

@juliusknorr juliusknorr added bug Something isn't working 3. to review log finding labels Mar 10, 2025
@juliusknorr juliusknorr requested a review from a team March 10, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working log finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant