Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop/vuex #6930

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

drop/vuex #6930

wants to merge 6 commits into from

Conversation

max-nextcloud
Copy link
Collaborator

  • chore(deps): upgrade vite to version 6
  • cleanup(vuex): unused clientWidth and its plugin
  • chore(cleanup): track headings without vuex
  • chore(cleanup): unused imageAttachments getter
  • chore(cleanup): use plain instance variable instead of vuex
  • chore(test): mock to reduce console.debugger noise

@max-nextcloud max-nextcloud requested a review from mejo- as a code owner March 1, 2025 15:31
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

Attention: Patch coverage is 94.64286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 46.74%. Comparing base (35db36e) to head (837b035).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Editor/Wrapper.vue 0.00% 1 Missing ⚠️
src/components/Menu/ActionList.vue 0.00% 1 Missing ⚠️
src/services/AttachmentResolver.js 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6930      +/-   ##
==========================================
+ Coverage   37.82%   46.74%   +8.92%     
==========================================
  Files         750      290     -460     
  Lines       42691    33956    -8735     
  Branches     1273      815     -458     
==========================================
- Hits        16146    15874     -272     
+ Misses      25923    17954    -7969     
+ Partials      622      128     -494     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

* Stop @nextcloud/capabilites logging that it cannot find initial state.
* Stop vue logging missing dev tools and production notice.

Signed-off-by: Max <[email protected]>
@juliusknorr juliusknorr requested a review from a team March 6, 2025 07:21
@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants