Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help modal improvements #6926

Merged
merged 3 commits into from
Mar 6, 2025
Merged

Help modal improvements #6926

merged 3 commits into from
Mar 6, 2025

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Feb 28, 2025

  • fix: Add missing shortcut for checklists to help modal
  • fix: Use proper mod key on macOS in help modal
  • fix: Change help modal size to force scrolling

📝 Summary

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot 2025-02-28 at 09 32 49 Screenshot 2025-02-28 at 09 31 33

@juliusknorr juliusknorr requested a review from a team February 28, 2025 08:33
@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Feb 28, 2025
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 37.94%. Comparing base (35db36e) to head (09b1c3e).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/components/HelpModal.vue 0.00% 2 Missing ⚠️
src/components/Suggestion/Mention/suggestions.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6926      +/-   ##
==========================================
+ Coverage   37.82%   37.94%   +0.12%     
==========================================
  Files         750      735      -15     
  Lines       42691    42546     -145     
  Branches     1273     1258      -15     
==========================================
  Hits        16146    16146              
+ Misses      25923    25793     -130     
+ Partials      622      607      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juliusknorr juliusknorr merged commit fbb0405 into main Mar 6, 2025
62 of 64 checks passed
@juliusknorr juliusknorr deleted the fix/checklist-shortcut branch March 6, 2025 07:21
@juliusknorr
Copy link
Member Author

/backport to stable30

@juliusknorr
Copy link
Member Author

/backport to stable31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add keyboard shortcut for checklist
3 participants