Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement event so collectives can inject custom notification messages #6923

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Implement event so collectives can inject custom notification messages #6923

wants to merge 1 commit into from

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Feb 27, 2025 •
edited
Loading

Base pr for nextcloud/collectives#1675 to allow the collectives app to set their own notification details for mentions within a collective.

@juliusknorr juliusknorr mentioned this pull request Feb 27, 2025
Open
4 tasks
@juliusknorr juliusknorr added enhancement New feature or request 3. to review labels Feb 27, 2025
@juliusknorr juliusknorr requested a review from a team February 27, 2025 16:05
@juliusknorr juliusknorr mentioned this pull request Feb 27, 2025
Open
max-nextcloud
max-nextcloud approved these changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good. Makes sense to have this. did not test it though.

... which also reminds me that it might be nice to have tests for this as it will be hard to notice if it breaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@mejo- mejo- Awaiting requested review from mejo- mejo- is a code owner

Assignees
No one assigned
Labels
3. to review enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliusknorr @max-nextcloud