Keep layout on sync errors #6903
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6903 +/- ##
==========================================
+ Coverage 37.82% 38.36% +0.54%
==========================================
Files 750 929 +179
Lines 42691 42410 -281
Branches 1273 1468 +195
==========================================
+ Hits 16146 16271 +125
+ Misses 25923 25376 -547
- Partials 622 763 +141 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
max-nextcloud
force-pushed
the
enh/keep-layout-on-sync-errors
branch
from
af40cfd to
d9d2506
Compare
marcoambrosini
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Looks good @max-nextcloud, let's just make sure that the margin from the bottom is of size --clickable-area
max-nextcloud
force-pushed
the
enh/keep-layout-on-sync-errors
branch
2 times, most recently
from
bff0826 to
adc0bdb
Compare
|
/backport to stable30 |
|
/backport to stable29 |
max-nextcloud
force-pushed
the
enh/keep-layout-on-sync-errors
branch
from
adc0bdb to
f14eb27
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
The document status div is full width. Its background hides the text behind it and scrollbars on the side. Introduce a new .status-wrapper div that sets the background and only has the size of the actual message. Also move the message to the very bottom of the screen on mobile. Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
Signed-off-by: Max <[email protected]>
max-nextcloud
force-pushed
the
enh/keep-layout-on-sync-errors
branch
from
f14eb27 to
678cd9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6877
Ui changes
🖼️ Screenshots
Other commits
☑️ TODO
--clickable-area