Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(AppDiscover): Ensure created cache folder is safe-chars only #51379

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(AppDiscover): Ensure created cache folder is safe-chars only #51379

wants to merge 1 commit into from
+3 −1

Conversation

solracsf
Copy link
Member

Checklist

@solracsf solracsf added the 2. developing Work in progress label Mar 10, 2025
@solracsf solracsf added this to the Nextcloud 32 milestone Mar 10, 2025
@solracsf solracsf mentioned this pull request Mar 10, 2025
Open
8 tasks
@solracsf solracsf added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 10, 2025
@solracsf solracsf marked this pull request as ready for review March 10, 2025 17:28
@solracsf solracsf requested a review from a team as a code owner March 10, 2025 17:28
@solracsf solracsf requested review from ArtificialOwl, artonge and sorbaugh and removed request for a team March 10, 2025 17:28
@solracsf
Copy link
Member Author

/backport to stable31

@solracsf
Copy link
Member Author

/backport to stable30

@kesselb

This comment was marked as outdated.

Sign in to view
@kesselb kesselb requested a review from susnux March 10, 2025 17:49
@kesselb kesselb added the bug label Mar 10, 2025
susnux

This comment was marked as outdated.

Sign in to view

@susnux susnux dismissed their stale review March 10, 2025 17:54

Too quickly

@susnux

This comment was marked as outdated.

Sign in to view
@susnux susnux self-requested a review March 10, 2025 17:55
@solracsf
Copy link
Member Author

solracsf commented Mar 10, 2025 •
edited
Loading

Maybe apply the same logic (strip double-quotes) here?

server/apps/settings/lib/Controller/AppSettingsController.php

Line 147 in eb59791

$folder = $folder->newFolder($etag);

EDIT: Applied the fix to the folder creation logic.

@solracsf solracsf force-pushed the appStoreCacheFolder branch from e364d09 to 124985c Compare March 10, 2025 18:06
@solracsf solracsf force-pushed the appStoreCacheFolder branch from 124985c to 659747e Compare March 10, 2025 18:11
@solracsf solracsf requested a review from kesselb March 10, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@artonge artonge Awaiting requested review from artonge artonge is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

@susnux susnux Awaiting requested review from susnux

@kesselb kesselb Awaiting requested review from kesselb

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
3. to review Waiting for reviews backport-request bug
Projects
None yet
Milestone
Nextcloud 32
Development

Successfully merging this pull request may close these issues.

[Bug]: Remote images in discover section in AppStore not loading if Windows filename compatibility is enabled
3 participants
@solracsf @kesselb @susnux