Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lookup-server): disable when not using global scale #51378

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(lookup-server): disable when not using global scale #51378

wants to merge 3 commits into from

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Mar 10, 2025

This PR consists of 3 commits:

  1. Switch upload data for lookup server to default false
  2. Switch query lookup server to default false
  3. Disable lookup server functionality if not on global scale

@susnux susnux added bug 3. to review Waiting for reviews labels Mar 10, 2025
@susnux susnux changed the title Fix/lookup server connector v2 fix(lookup-server): disable when not using global scale Mar 10, 2025
@susnux susnux marked this pull request as ready for review March 10, 2025 14:58
@susnux susnux requested review from a team as code owners March 10, 2025 14:58
@susnux susnux requested review from artonge, Pytal, sorbaugh and yemkareems and removed request for a team March 10, 2025 14:58
@susnux susnux force-pushed the fix/lookup-server-connector-v2 branch 2 times, most recently from 4d95896 to 172b661 Compare March 10, 2025 15:17
nickvergessen
nickvergessen reviewed Mar 10, 2025
View reviewed changes
@susnux susnux force-pushed the fix/lookup-server-connector-v2 branch from 172b661 to 8787c75 Compare March 10, 2025 15:24
@susnux susnux requested a review from nickvergessen March 10, 2025 15:26
@susnux susnux force-pushed the fix/lookup-server-connector-v2 branch from 8787c75 to d899b57 Compare March 10, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

@artonge artonge Awaiting requested review from artonge artonge is a code owner automatically assigned from nextcloud/server-frontend

@Pytal Pytal Awaiting requested review from Pytal Pytal is a code owner automatically assigned from nextcloud/server-frontend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-frontend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@susnux @nickvergessen