Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(login): Properly target public page with attribute #51280

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Mar 5, 2025

Follow-up of #51051
FIx #51248

@artonge artonge requested a review from a team as a code owner March 5, 2025 11:50
@artonge artonge requested review from icewind1991, sorbaugh and come-nc and removed request for a team March 5, 2025 11:50
@artonge artonge self-assigned this Mar 5, 2025
@artonge artonge added bug 3. to review Waiting for reviews php Pull requests that update Php code labels Mar 5, 2025
@artonge
Copy link
Contributor Author

artonge commented Mar 5, 2025

/backport to stable31

@artonge
Copy link
Contributor Author

artonge commented Mar 5, 2025

/backport to stable30

@artonge
Copy link
Contributor Author

artonge commented Mar 5, 2025

/backport to stable29

@artonge
Copy link
Contributor Author

artonge commented Mar 5, 2025

/backport to stable28

@artonge
Copy link
Contributor Author

artonge commented Mar 5, 2025

/backport to stable27

@artonge
Copy link
Contributor Author

artonge commented Mar 5, 2025

/backport to stable26

@artonge
Copy link
Contributor Author

artonge commented Mar 5, 2025

/backport to stable25

@artonge artonge added this to the Nextcloud 32 milestone Mar 5, 2025
@artonge artonge requested review from susnux and Altahrim March 5, 2025 11:52
Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works with the iOS Files App. Thanks!

@artonge artonge force-pushed the artonge/fix/publicpage_attribute branch from 5d68d8b to a163fa0 Compare March 5, 2025 15:36
@artonge artonge merged commit 3459ff9 into master Mar 5, 2025
190 checks passed
@artonge artonge deleted the artonge/fix/publicpage_attribute branch March 5, 2025 16:54
Copy link

backportbot bot commented Mar 5, 2025

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25

# Create the new backport branch
git checkout -b backport/51280/stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a163fa08

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/51280/stable25

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request bug php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: LoginV2 regression - redirect to login after grant
3 participants