Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): Don't do session related work in the constructor of the View #51259

Merged
merged 2 commits into from
Mar 5, 2025
Merged

fix(files): Don't do session related work in the constructor of the View #51259

merged 2 commits into from
Mar 5, 2025

Conversation

nickvergessen
Copy link
Member

Checklist

@nickvergessen nickvergessen requested a review from a team as a code owner March 5, 2025 08:00
@nickvergessen nickvergessen requested review from ArtificialOwl, nfebe and provokateurin and removed request for a team March 5, 2025 08:00
@nickvergessen nickvergessen self-assigned this Mar 5, 2025
@nickvergessen nickvergessen added this to the Nextcloud 32 milestone Mar 5, 2025
@nickvergessen nickvergessen force-pushed the bugfix/50619/no-session-work-in-constructor branch from d7f7b70 to 0522b03 Compare March 5, 2025 08:06
@SystemKeeper
fix: No IFactory in constructor
3391279 
Signed-off-by: Marcel Müller <[email protected]>
provokateurin
provokateurin approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫣

@digletthat digletthat mentioned this pull request Mar 5, 2025
Closed
8 tasks
@SystemKeeper
Copy link
Contributor

We got confirmation from 3 users, that the patch works!

@provokateurin provokateurin merged commit 4a6fd95 into master Mar 5, 2025
190 checks passed
@provokateurin provokateurin deleted the bugfix/50619/no-session-work-in-constructor branch March 5, 2025 11:30
@provokateurin
Copy link
Member

Backports needed?

@susnux
Copy link
Contributor

susnux commented Mar 5, 2025

/backport to stable31

@susnux
Copy link
Contributor

susnux commented Mar 5, 2025

/backport to stable30

This was referenced Mar 5, 2025
Merged
Merged
@susnux
Copy link
Contributor

susnux commented Mar 5, 2025

/backport to stable29

@backportbot backportbot bot mentioned this pull request Mar 5, 2025
Merged
@blizzz
Copy link
Member

blizzz commented Mar 5, 2025

/backport to stable28

@backportbot backportbot bot mentioned this pull request Mar 5, 2025
Merged
2 tasks
@synthead synthead mentioned this pull request Mar 5, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@susnux susnux susnux approved these changes

@provokateurin provokateurin provokateurin approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews bug feature: filesystem
Projects
None yet
Milestone
Nextcloud 32
Development

Successfully merging this pull request may close these issues.

[Bug]: Can't login from iOS client app
6 participants
@nickvergessen @SystemKeeper @provokateurin @susnux @blizzz @AndyScherzinger