fix: Deprecate OC_Template, add proper template manager instead #51029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
force-pushed
the
fix/deprecate-oc-template-and-cleanup
branch
from
0573048 to
ddc5106
Compare
come-nc
force-pushed
the
fix/deprecate-oc-template-and-cleanup
branch
3 times, most recently
from
8d9a88c to
960b2b5
Compare
come-nc
requested review from
ChristophWurst,
miaulalala,
nickvergessen and
st3iny
as code owners
come-nc
added
3. to review
|
CI failure unrelated |
|
Eh I started commenting on the first commit, but then saw you cleaned up stuff in the other commits. Would it be better to just review the entire diff at once instead of commit-by-commit? |
Hum, maybe use the range commit feature to still review the change to API first, and the call changes and templatelayout changes on their own after? |
come-nc
requested review from
ArtificialOwl and
artonge
and removed request for
a team
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
It is not needed anymore since OCP\Util::addScript is used directly now, and not the function "script" from template functions. Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
fix/deprecate-oc-template-and-cleanup
branch
from
bc37c9b to
b086f10
Compare
ChristophWurst
approved these changes
Mar 6, 2025
| * | ||
| * @param IUser $user | ||
| * @return Template | ||
| * @since 32.0.0 Broader return type ITemplate instead of \OCP\Template. |
There was a problem hiding this comment.
That's a nice way forward without breakage 👏
| interface ITemplate { | ||
| /** | ||
| * Process the template | ||
| * @since 32.0.0 |
There was a problem hiding this comment.
nit: return value could be documented. I'm assuming it's the template HTML
susnux
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a proper manager with an interface for templates.
Deprecate legacy
OC_Templateas well as\OCP\Templateclass which was used as a public constructor.TODO
Checklist