feat: Only getShares for provided types

With the types filter in place (1e7f53e) we should avoid, fetching all shares. Preventing potential N+1s Signed-off-by: nfebe <[email protected]>
nextcloud · Mar 7, 2025 · cca22cb · cca22cb
1 parent a57e88a
commit cca22cb
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/apps/files_sharing/lib/Controller/ShareAPIController.php b/apps/files_sharing/lib/Controller/ShareAPIController.php
@@ -1068,7 +1068,7 @@ private function getFormattedShares(
 			return $this->getSharesInDir($node);
 		}
 
-		$shares = $this->getSharesFromNode($viewer, $node, $reShares);
+		$shares = $this->getSharesFromNode($viewer, $node, $reShares, $types);
 
 		$known = $formatted = $miniFormatted = [];
 		$resharingRight = false;
@@ -1883,7 +1883,7 @@ private function getSciencemeshShareHelper() {
 	 *
 	 * @return IShare[]
 	 */
-	private function getSharesFromNode(string $viewer, $node, bool $reShares): array {
+	private function getSharesFromNode(string $viewer, $node, bool $reShares, array $limitToProviders = []): array {
 		$providers = [
 			IShare::TYPE_USER,
 			IShare::TYPE_GROUP,
@@ -1895,6 +1895,10 @@ private function getSharesFromNode(string $viewer, $node, bool $reShares): array
 			IShare::TYPE_SCIENCEMESH
 		];
 
+		if (count($limitToProviders) > 0) {
+			$providers = $limitToProviders;
+		}
+
 		// Should we assume that the (currentUser) viewer is the owner of the node !?
 		$shares = [];
 		foreach ($providers as $provider) {