Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui/tray: Fix some tray view papercuts #7937

Merged
merged 5 commits into from
Mar 3, 2025
Merged

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Feb 27, 2025

Screenshot 2025-02-27 at 17 32 00 Screenshot 2025-02-27 at 15 50 09

@claucambra claucambra added this to the 3.16.0 milestone Feb 27, 2025
@claucambra claucambra self-assigned this Feb 27, 2025
@nilsding
Copy link
Member

Windows testing:

  • app menu looks fine
  • status buttons are cut off (maybe we should stack them vertically like they're in Talk?)
  • there's a weird vertical line with the windows11 QML style in the status input fields

Screenshot_20250227_094135-1

Screenshot_20250227_094249

@claucambra
Copy link
Collaborator Author

Windows testing:

  • status buttons are cut off (maybe we should stack them vertically like they're in Talk?)

I think this would really compress the other UI elements... Maybe we can change the text to just "Cancel" / "Clear" / "Apply"

  • there's a weird vertical line with the windows11 QML style in the status input fields

Looks like there is some weirdness with the background maybe?

@nilsding
Copy link
Member

Maybe we can change the text to just "Cancel" / "Clear" / "Apply"

good idea!

Looks like there is some weirdness with the background maybe?

yep... just to see what it looked like I removed the background properties altogether (and changing the emoji button from AbstractButton to Button) and... it doesn't even look that bad on Windows

Screenshot_20250227_100632

@claucambra
Copy link
Collaborator Author

Looks like there is some weirdness with the background maybe?

yep... just to see what it looked like I removed the background properties altogether (and changing the emoji button from AbstractButton to Button) and... it doesn't even look that bad on Windows

![Screenshot_20250227_100632](https://private-user-images.githubusercontent.com/1809170/417516362-9e1b7dc8-a075-41e7-b193-370528bb8051.png?

Unfortunately on macOS this approach leads to a totally borked button ☹️ I think we can keep the button semi custom styled with a simpler background until we have a better solution

@claucambra
Copy link
Collaborator Author

@nilsding with latest changes

Screenshot 2025-02-27 at 17 32 00

@claucambra claucambra requested a review from nilsding February 27, 2025 09:34
@nilsding
Copy link
Member

I think we can keep the button semi custom styled with a simpler background until we have a better solution

also fine -- as long as it's obvious enough that one can click on it

@camilasan
Copy link
Member

on Linux:
linux
linux-apps

@nilsding
Copy link
Member

uh, dark mode again

@claucambra
Copy link
Collaborator Author

on Linux: linux linux-apps

My hunch is that this might be an issue with our interaction with Breeze, are you running the AppImage?

@claucambra claucambra added the feature: ☁️ GUI System tray icon and menu. label Feb 28, 2025
@camilasan
Copy link
Member

My hunch is that this might be an issue with our interaction with Breeze, are you running the AppImage?

no

@camilasan camilasan force-pushed the bugfix/ui-papercuts-tray branch from 0b90f7b to 55d5d7f Compare March 3, 2025 12:41
@Rello
Copy link
Contributor

Rello commented Mar 3, 2025

Bildschirmfoto 2025-03-03 um 13 43 59

can you double check? RC3 on macOS resizes the dropdown when resizing the window?!

Copy link

github-actions bot commented Mar 3, 2025

Artifact containing the AppImage: nextcloud-appimage-pr-7937.zip

SHA256 checksum: c22010751d969a484621fe3f3fece891d0124ebe874b3f2b7ccb993944c2da8c

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien force-pushed the bugfix/ui-papercuts-tray branch from 55d5d7f to 8438f88 Compare March 3, 2025 16:17
@mgallien
Copy link
Collaborator

mgallien commented Mar 3, 2025

/backport to stable-3.16

@mgallien mgallien merged commit f86f5af into master Mar 3, 2025
9 of 14 checks passed
@mgallien mgallien deleted the bugfix/ui-papercuts-tray branch March 3, 2025 16:18
Copy link

sonarqubecloud bot commented Mar 3, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: ☁️ GUI System tray icon and menu.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants