don't remove "needs info" label from maintainers #7934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replaces syntax to yaml multi-line, apparently `${{ ... }}` was only
needed because the expression starts with a `!`
- since GitHub workflows only have literals for booleans, null, number,
and string, we need to use `fromJSON` in order to create an array as
per the example given in the docs for `contains`
see also:
- https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idif
- https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions#example-matching-an-array-of-strings
- https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions#literals
Signed-off-by: Jyrki Gadinger <[email protected]>
|
Artifact containing the AppImage: nextcloud-appimage-pr-7934.zip SHA256 checksum: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
camilasan
approved these changes
Feb 26, 2025
|
claucambra
approved these changes
Feb 27, 2025
claucambra
deleted the
github/ignore-needsinfo-removal-from-maintainers
branch
|
seems to work like a charm :D
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just taking care some small annoyance I noticed during issue triaging, sometimes I'm faster adding the label before the workflow runs through... I hope this works as expected ;-)
${{ ... }}was only needed because the expression starts with a!fromJSONin order to create an array as per the example given in the docs forcontainssee also: