Added customize option for sync interval #7926
Conversation
|
/backport to stable-3.16 |
|
Hi! I've fixed the issues you mentioned. |
Pabarino
force-pushed
the
enhancement/2792
branch
2 times, most recently
from
24ecf53 to
a87271e
Compare
|
No worries, I carried out the changes you suggested. Thanks! |
… Settings Signed-off-by: Pablo Ariño Muñoz <[email protected]>
Signed-off-by: Pablo Ariño Muñoz <[email protected]>
Signed-off-by: Pablo Ariño Muñoz <[email protected]>
Signed-off-by: Pablo Ariño Muñoz <[email protected]>
claucambra
force-pushed
the
enhancement/2792
branch
from
a87271e to
a62976c
Compare
|
|
||
| _ui->labelInterval->setText("seconds (if <a href=\"https://github.com/nextcloud/notify_push\">Client Push</a> is unavailable)"); | ||
| _ui->labelInterval->setTextFormat(Qt::RichText); | ||
| _ui->labelInterval->setTextInteractionFlags(Qt::TextBrowserInteraction); | ||
| _ui->labelInterval->setOpenExternalLinks(true); |
There was a problem hiding this comment.
bit late for a review, but anyway :)
I'd rather have these properties of the label be part of the designer file. The call to setText will also lose the translated texts coming out from the designer file...
There was a problem hiding this comment.
@Pabarino would you be up for a follow up PR? 🙈
I would be nice to hide the select if notify push is available. I believe there is a capability value that can be checked for it.
There was a problem hiding this comment.
@Pabarino would you be up for a follow up PR? 🙈 I would be nice to hide the select if notify push is available. I believe there is a capability value that can be checked for it.
Hi! Sure, I'll give it a go.
bit late for a review, but anyway :)
I'd rather have these properties of the label be part of the designer file. The call to
setTextwill also lose the translated texts coming out from the designer file...
I'll fix this too while I'm at it.
There was a problem hiding this comment.
Hi!, just requested the PR: #7941
Added an option to the Advanced section in General Settings that allows the user to modify the sync interval.
Checked the nextcloud.cfg file and it works:
I think this would solve issue #2792