Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UI of settings #7902

Merged
merged 4 commits into from
Feb 25, 2025
Merged

Improve UI of settings #7902

merged 4 commits into from
Feb 25, 2025

Conversation

camilasan
Copy link
Member

@camilasan camilasan commented Feb 20, 2025 •
edited
Loading

Before
Screenshot 2025-02-20 at 19 31 51

After
Screenshot 2025-02-20 at 19 39 50

Screenshot 2025-02-20 at 19 57 29

@camilasan camilasan added this to the 3.16.0 milestone Feb 20, 2025
@camilasan
Copy link
Member Author

/backport to stable-3.16

nilsding
nilsding requested changes Feb 21, 2025
View reviewed changes
Copy link
Member

@nilsding nilsding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, looks good otherwise :>

camilasan and others added 4 commits February 25, 2025 10:11
@camilasan
Update help url default value.
5f87576 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Remove help url from developer string.
2009837 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Adjust layout margins to align text.
3fd564a 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan @nilsding
Remove helpUlr() call from string.
5c78ddb 
Co-authored-by: Jyrki Gadinger <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
@github-actions GitHub Actions
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-7902.zip

SHA256 checksum: a120a9051ce547672ef4b1b57d2ad8a5df5177e6be2de6805e117990334024ec

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7 New Code Smells (required ≤ 0)
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@nilsding nilsding merged commit 0dca701 into master Feb 25, 2025
13 of 16 checks passed
@nilsding nilsding deleted the bugfix/settings branch February 25, 2025 10:03
@backportbot backportbot bot mentioned this pull request Feb 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsding nilsding nilsding approved these changes

@claucambra claucambra claucambra approved these changes

@mgallien mgallien Awaiting requested review from mgallien mgallien is a code owner

@Rello Rello Awaiting requested review from Rello

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@camilasan @nilsding @claucambra