fix(NcAction*): complete BiDi support #6507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
added
bug
susnux
approved these changes
Feb 12, 2025
|
/backport to next |
ShGKme
approved these changes
Feb 13, 2025
| top: auto; | ||
| width: 1px; | ||
| height: 1px; | ||
| overflow: hidden; | ||
| z-index: -1; | ||
| opacity: 0; |
There was a problem hiding this comment.
A general note: opacity: 0 must be redundant.
- If an element is not visible already -
opacity: 0does nothing - If an element is actually visible -
opacity: 0hides it from view, but the element still exists and might block interactions or have other unexpected effects
But this element is hidden anyway by the server styles, and both old and new visually hidden approaches are not correct here, so can be properly fixed later.
Hidden input must be in the same place as the visual one. Screen reader will focus and select the real <input>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
left: -10000px;was replaced with different handling, as it might affect scrolling (although we don't have a horizontal one, it seems better to keep native elements within the component area, not outside of screen)🖼️ Screenshots
No visual changes (for LTR)
🏁 Checklist
nextrequested with a Vue 3 upgrade