-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcActionRadio): change modelValue to behave like NcCheckboxRadioSwitch #6264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
approved these changes
Jan 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense from my point of view and probably makes usage simpler
raimund-schluessler
approved these changes
Jan 26, 2025
…witch Signed-off-by: Maksim Sukharev <[email protected]>
0385abf
to
1c50065
Compare
Signed-off-by: Maksim Sukharev <[email protected]>
/backport to next |
ShGKme
reviewed
Jan 27, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
enhancement
New feature or request
feature: actions
Related to the actions components
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
v-model: Boolean
is quite unusable for radio-buttons, as it should store selected value (one from many options)checked
tov-model
, apart from that works as before🖼️ Screenshots
🚧 Tasks
this.model = this.$refs.radio.checked
is kept for backward compatibility🏁 Checklist
next
requested with a Vue 3 upgrade