Multiselect fixes

[skjnldsv]

• Border radius fixes
• Padding increase
• Removed triangle on single select

Before	After

@jancborchardt I did not removed the user icon as this is actually a standard (you can use any icon you want like we do in the sharing with nextcloud/server#11899)

[ChristophWurst]

Code looks good

Would you mind splitting these separate features for future PRs and provide before/after screenshots? That would be great!

[ChristophWurst]

Would you mind splitting these separate features for future PRs and provide before/after screenshots? That would be great!

Background: "Multiselect fixes" is just too generic. There will be many more of these fixes and knowing that has changed in a release of this lib will be hard to understand for anybody using this in their app.

[skjnldsv]

Background: "Multiselect fixes" is just too generic. There will be many more of these fixes and knowing that has changed in a release of this lib will be hard to understand for anybody using this in their app.

Commit comment is more detailed for this purpose ;)
Let me add some screenshots :)

[ChristophWurst]

Commit comment is more detailed for this purpose ;)

Yep, saw that, thanks! IMO still is a valid concern to have this separated as it also makes it possible to revert a single fix if it causes any issue.

[skjnldsv]

@ChristophWurst updated op :)

[jancborchardt]

@skjnldsv good stuff, thanks!

did not removed the user icon as this is actually a standard

If I want to propose to only have an icon for when it's not a single user (which is the default) should I just open an issue here?

(Cause right now with all entries having an icon, the icon becomes quite meaningless as it's almost always the same.)

[skjnldsv]

I'd say this should be a common sense usage rule then, because it make sense to have the icon for other things like an entry that represent a circle, a talk convo... (or god knows why 🤔 ).
If I get you right, you mean that since the user is the default data item, we should not display the user icon but all the other ones are fine, correct? 😉

@ChristophWurst @juliushaertl I don't think we should prevent this specific icon (icon-user), but on the other hand, if we could be sure devs would follow this common sense usage rule, then we'd be in a dream world! Thoughts? 😁

[jancborchardt]

If I get you right, you mean that since the user is the default data item, we should not display the user icon but all the other ones are fine, correct? 😉

Exactly. :)

I don't think we should prevent this specific icon (icon-user), but on the other hand, if we could be sure devs would follow this common sense usage rule, then we'd be in a dream world!

I also don’t think we should prevent it. But a good start would be:

• We don’t use it in our example apps or building blocks or in the docs cause that’s how people see what we expect. Which is why I mentioned it here.
• In the docs we say something like "On the right you can show an icon signifying if it’s a group, a Talk conversation or something else special. If it is just a person, no icon is needed."

What do you think?