conn: use /usr/bin/env to run the shell

[pbrezina]

To make the code more portable to distributions that don't have bash in
/usr/bin.

[alejandro-colomar]

Cc: @ikerexxe

For commit 2 (where the meat is), please add:

Link: <https://github.com/shadow-maint/shadow/pull/1131>
Reported-by: Iker Pedrosa <[email protected]>
Reported-by: Alejandro Colomar <[email protected]>
Suggested-by: Alejandro Colomar <[email protected]>

The patch LGTM. Thanks!

[pbrezina]

Cc: @ikerexxe

For commit 2 (where the meat is), please add:

Link: <https://github.com/shadow-maint/shadow/pull/1131>
Reported-by: Iker Pedrosa <[email protected]>
Reported-by: Alejandro Colomar <[email protected]>
Suggested-by: Alejandro Colomar <[email protected]>

Done

[ikerexxe]

There's another mention of /usr/bin/bash -c in pytest_mh/_private/multihost.py, it's a comment so it wouldn't be a big deal to forget about it, but I'd prefer to update it and have everything aligned.

Apart from that it looks good. Will you be able to generate a new release after these changes are merged? I'd like to pin a specific version of pytest-mh in shadow.

[ikerexxe]

There's another mention of /usr/bin/bash -c in pytest_mh/_private/multihost.py, it's a comment so it wouldn't be a big deal to forget about it, but I'd prefer to update it and have everything aligned.

It was already removed in the first commit 🤦

[ikerexxe]

LGTM!