Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing content-type on combined JS file response #20

Merged
merged 2 commits into from
Mar 2, 2017
Merged

Fixing content-type on combined JS file response #20

merged 2 commits into from
Mar 2, 2017

Conversation

EricSeastrand
Copy link
Contributor

Fixes issue #14

Making the x.js script automatically detect and pass back the correct content type so that it isn't necessary to comment out the "Header set X-Content-Type-Options: nosniff" line in htaccess.
Fixes issue 14.
Fixing content type mismatch issue on auth.phtml
@miguelbalparda
Copy link
Contributor

Can you point this to devel instead of master please?

@EricSeastrand EricSeastrand changed the base branch from master to devel December 22, 2016 14:45
@EricSeastrand
Copy link
Contributor Author

Updated

@peepsnet
Copy link

peepsnet commented Mar 2, 2017

This fixed my issue in MagentoCE 1.9.3.2

This should be merged

@miguelbalparda miguelbalparda merged commit 450a9f3 into nexcess:devel Mar 2, 2017
@miguelbalparda
Copy link
Contributor

Thank you for your contribution @willcodeforfood!

@TheRealJAG
Copy link

@miguelbalparda I'm still seeing this issue on Magento ver. 1.9.3.6

When I close the browser and go directly to the admin I see this:
dashboard

I'm still able to browse around the admin. When I logged out, I don't see the error.

I'm going to assume devel is not production ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants