ci: Move init container release from lambda to GHA #2848
Conversation
|
|
hmstepanek
force-pushed
the
move-release-from-lambda-to-gha
branch
from
0c58738 to
f8bd739
Compare
hmstepanek
changed the title
hmstepanek
changed the title
|
@hmstepanek I know this is in draft but do you mind linking what this is replacing? |
hmstepanek
force-pushed
the
move-release-from-lambda-to-gha
branch
from
ff8d07b to
47824cb
Compare
There was a problem hiding this comment.
I'm not convinced the new job belongs in this workflow. We will have occasion to run this workflow manually in order to regenerate our docs (either in the local repo, the main NR docs repo, or both). The way this new job is configured, by its if clause, will have it running whenever this workflow is triggered. Is that desired? I have a hunch that it is not desired. I am thinking that this job deserves its own workflow.
.github/workflows/post-release.yml
Outdated
| @@ -65,3 +65,34 @@ jobs: | |||
| GITHUB_TOKEN: ${{ secrets.NODE_AGENT_GH_TOKEN }} | |||
| GITHUB_USER: ${{ vars.NODE_AGENT_CI_USER_NAME }} | |||
| GITHUB_EMAIL: ${{ vars.NODE_AGENT_CI_USER_EMAIL }} | |||
|
|
|||
| release-tags: | |||
There was a problem hiding this comment.
I believe this job changes the description of the workflow on line 7, at the very least.
There was a problem hiding this comment.
I'm not a GHA expert so forgive me. Which line in this is causing it to override the description? Line 69 is just the name of the job so that shouldn't override the description as far as I know.
I can certainly make this it's own workflow. I can understand wanting to run the docs separately on occasion.
There was a problem hiding this comment.
I'm not saying that your addition is overriding the description. I'm saying that the changes are not in line with the description, aka changes the stated purpose of the workflow.
|
@hmstepanek I'm not sure why the CLA isn't auto-acknowledging you as an employee but can you sign it? Also, where is the value of the |
The value of the token is shared in the 1password agent shared credentials area as |
|
When is this supposed to be merged? |
|
I added secret to repo |
Description
We are getting rid of the internal auto-layer-releases repo and moving creating of the release tags into each agent's GHA deploy flow.