refactor: Removed class construction on the segment synthesis and ins… #2837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will need to rebase once #2836 is merged because it fixes the unit test failure |
jsumners-nr
previously approved these changes
Dec 16, 2024
bizob2828
dismissed
jsumners-nr’s stale review
The merge-base changed after approval.
…tead provided utility functions that return segment and transaction
bizob2828
force-pushed
the
refactor-server-synthesis
branch
from
a761c17 to
e0b5554
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2837 +/- ##
==========================================
- Coverage 97.35% 97.35% -0.01%
==========================================
Files 303 303
Lines 47148 47141 -7
==========================================
- Hits 45903 45896 -7
Misses 1245 1245
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jsumners-nr
approved these changes
Dec 16, 2024
bizob2828
added a commit
that referenced
this pull request
Dec 19, 2024
bizob2828
added a commit
that referenced
this pull request
Jan 13, 2025
bizob2828
added a commit
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tead provided utility functions that return segment and transaction
Description
In #2833 there was a comment about the classes for the different segment synthesis wasn't the appropriate data structure. This Pr refactors those files into helper methods for construction the segment and transactions(for server otel spans)