Only start telemetry handlers when agent is enabled #474
+33
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
binaryseed
commented
Jan 3, 2025
•
binaryseed
commented
- We only need to start telemetry handlers when the agent is enabled. This avoids extra work in the application in situations where the agent is disabled (ex: tests)
- Also adds a config flag to bypass making collector http requests so we can test things w/o trying to actually connect to the collector
binaryseed
force-pushed
the
vince/conditionally-start-telemetry-handlers
branch
2 times, most recently
from
9694714 to
7d1c4b3
Compare
binaryseed
force-pushed
the
vince/conditionally-start-telemetry-handlers
branch
from
7d1c4b3 to
87866ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.