RN(serverless): Serverless release note #18732
Conversation
cbehera-newrelic
commented
Sep 20, 2024
cbehera-newrelic
commented
- Created a release note section for Serverless monitoring.
cbehera-newrelic
added
content
|
Hi @cbehera-newrelic 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). |
✅ Deploy Preview for docs-website-netlify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| version: 2.3.11 | ||
| --- | ||
|
|
||
| ## Notes |
There was a problem hiding this comment.
This note section is a little confusing, are the crashes being fixed or are we notifying customers that they are happening?
|
|
||
| * Gives priority to `NEW_RELIC_LICENSE_KEY` and bypass calls to `Secrets Manager` if `NEW_RELIC_LICENSE_KEY` is set. | ||
|
|
||
| * Handle Extension Warning for Node.js handlers using ES Modules. Even after accurately modifying the lambda handler to use newrelic-lambda-wrapper.handler and setting the environment variable NEW_RELIC_LAMBDA_HANDLER to be path to the initial handler, Extension was throwing warning. Used NEW_RELIC_USE_ESM to understand that customer is using ES module. |
There was a problem hiding this comment.
The last sentence is grammatically incorrect and needs to be fixed to say "to understand that the customer was using the ES module." (or an ES module, I'm not sure if there are multiple)
|
|
||
| ## Notes | ||
|
|
||
| * Adds local testing for Extension. Local testing is enabled by setting `NEWRELIC_LOCAL_TESTING` to true. Currently it supports only Python runtime. It generates the lambda layers for `x86` and `arm` architecture layers using `publish.sh` script and invokes the test Lambdas using `test.sh` script. |
There was a problem hiding this comment.
Can we please add back ticks to true, example true
There was a problem hiding this comment.
Suggestion for rephrase:
Adds local testing for Extension. Local testing is enabled by setting NEWRELIC_LOCAL_TESTING to true. Currently supports Python runtime only, and generates lambda layers for x86 and arm architecture using publish.sh and invokes the test Lambdas using test.sh script.
|
|
||
| * Removes debug logs which get printed for each log line. Modifies confusing message log - mainLoop: blocking is confusing customer and adds payloadSize to the log message `Telemetry client error: %s, payload size: %d bytes"`. | ||
|
|
||
| * Updates on .NET Extension example to use newly released New Relic .NET lambda layer instead of OpenTracing. |
There was a problem hiding this comment.
Suggestion:
Lamda should be in upper case
Changed "lambda" to "Lambda"
Fixed review comments.
