-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(errors): new request errors page for mobile monitoring #18692
Conversation
Hi @ally-sassman 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). |
✅ Deploy Preview for docs-website-netlify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ally-sassman thanks for adding this new doc! I inserted a few questions and suggestions.
|
||
### Profiles [#error-profiles] | ||
|
||
Error profiles provide visual details about significant differences in the frequency of different values for HTTP error events. For each attribute, the error profile includes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ally-sassman where is this in the UI?
|
||
### Attributes [#attributes] | ||
|
||
Each request error sample provides detailed information about the request, response as well as the parameters that led to the request erroring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ally-sassman there's no mention of attributes here--only in the figcaption.
Co-authored-by: Rob Siebens <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ally-sassman This looks good. I just had one more small suggestion you can take or leave.
Jira: NR-311590
This PR includes the following changes: