Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(errors): new request errors page for mobile monitoring #18692

Merged
merged 13 commits into from
Sep 23, 2024

Conversation

ally-sassman
Copy link
Contributor

Jira: NR-311590

This PR includes the following changes:

  • Add a new page for group request errors
  • Remove the old http errors apge

Copy link

Hi @ally-sassman 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 68cb513
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/66edec86701eb7000831daa0
😎 Deploy Preview https://deploy-preview-18692--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ally-sassman ally-sassman self-assigned this Sep 17, 2024
@ally-sassman ally-sassman added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Sep 17, 2024
@ally-sassman ally-sassman marked this pull request as ready for review September 19, 2024 22:36
Copy link
Contributor

@rhetoric101 rhetoric101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ally-sassman thanks for adding this new doc! I inserted a few questions and suggestions.

src/content/docs/errors-inbox/group-request-errors.mdx Outdated Show resolved Hide resolved
src/content/docs/errors-inbox/group-request-errors.mdx Outdated Show resolved Hide resolved
src/content/docs/errors-inbox/group-request-errors.mdx Outdated Show resolved Hide resolved

### Profiles [#error-profiles]

Error profiles provide visual details about significant differences in the frequency of different values for HTTP error events. For each attribute, the error profile includes:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ally-sassman where is this in the UI?

src/content/docs/errors-inbox/group-request-errors.mdx Outdated Show resolved Hide resolved
src/content/docs/errors-inbox/group-request-errors.mdx Outdated Show resolved Hide resolved
src/content/docs/errors-inbox/group-request-errors.mdx Outdated Show resolved Hide resolved
src/content/docs/errors-inbox/group-request-errors.mdx Outdated Show resolved Hide resolved
src/content/docs/errors-inbox/group-request-errors.mdx Outdated Show resolved Hide resolved

### Attributes [#attributes]

Each request error sample provides detailed information about the request, response as well as the parameters that led to the request erroring.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ally-sassman there's no mention of attributes here--only in the figcaption.

rhetoric101
rhetoric101 previously approved these changes Sep 20, 2024
Copy link
Contributor

@rhetoric101 rhetoric101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ally-sassman This looks good. I just had one more small suggestion you can take or leave.

src/content/docs/errors-inbox/group-request-errors.mdx Outdated Show resolved Hide resolved
@ally-sassman ally-sassman merged commit 850939d into develop Sep 23, 2024
20 checks passed
@ally-sassman ally-sassman deleted the http-request-errors-inbox branch September 23, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants