Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improvement] Add directions for instrumenting a mixed Windows/Linux Kubernetes cluster #16646

Merged
merged 9 commits into from
Apr 5, 2024

Conversation

maxlemieux
Copy link
Contributor

  • What problems does this PR solve?
    We don't document Kubernetes integration installation for a mixed cluster today.

  • Add any context that will help us review your changes such as testing notes,
    links to related docs, screenshots, etc.

This recipe has been tested on mixed clusters on AKS and is drawn from a combination of two public docs:

Preview Windows installation (Only describes newrelic-infrastructure v2 installation, does not address anything else in the bundle): https://docs.newrelic.com/docs/kubernetes-pixie/kubernetes-integration/installation/kubernetes-integration-install-configure/#windows-install

Helm installation (Only addresses the bundle on Linux, does not address Windows): https://docs.newrelic.com/docs/kubernetes-pixie/kubernetes-integration/installation/kubernetes-integration-install-configure/#man-helm

maxlemieux and others added 3 commits March 21, 2024 16:17
Added the steps to install K8s integration on a cluster with mix of Linux and Windows nodes
simplified some directions
@CLAassistant
Copy link

CLAassistant commented Mar 22, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

Hi @maxlemieux 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). If you add any more commits, you can comment netlify build on this PR to update the preview.

Copy link

netlify bot commented Mar 22, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 4ea835e
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/660d9fd0d406530008f5a0aa
😎 Deploy Preview https://deploy-preview-16646--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nbaenam nbaenam self-requested a review March 26, 2024 09:40
@nbaenam nbaenam self-assigned this Mar 26, 2024
@nbaenam nbaenam added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Mar 26, 2024
@maxlemieux
Copy link
Contributor Author

Thanks for all the improvements. I fixed '2002' to '2022' with that last commit.

@maxlemieux
Copy link
Contributor Author

@bpschmitt when you have time, could you please review this content from @inderjeet-sandy and me? Thanks.

Copy link
Contributor

@nbaenam nbaenam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maxlemieux. I've added a new commit with my changes. Let me know if you have questions.

@nbaenam
Copy link
Contributor

nbaenam commented Apr 5, 2024

Hi @bpschmitt, any update on this? Could we merge this PR? Thanks!

@bpschmitt
Copy link
Contributor

@nbaenam go ahead and merge it. I'll come back and open another PR with some minor updates later.

@nbaenam nbaenam merged commit 33eb2fe into newrelic:develop Apr 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants