Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounts: Add caveats about consumption #14913

Merged
merged 9 commits into from
Dec 6, 2023

Conversation

rhetoric101
Copy link
Contributor

No description provided.

@rhetoric101 rhetoric101 added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Oct 18, 2023
@rhetoric101 rhetoric101 self-assigned this Oct 18, 2023
@github-actions
Copy link

Hi @rhetoric101 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@github-actions github-actions bot requested a review from paperclypse October 18, 2023 23:53
@gatsby-cloud
Copy link

gatsby-cloud bot commented Oct 19, 2023

✅ docs-website-develop deploy preview ready

@paperclypse
Copy link
Contributor

@rhetoric101 I missed this one. Do you still need a review/approval on it?

@rhetoric101
Copy link
Contributor Author

@paperclypse I am still waiting on an SME for approval.

@paperclypse
Copy link
Contributor

@rhetoric101 Let's close this one for now and re-open it when the SME gets back to you.

@rhetoric101
Copy link
Contributor Author

@paperclypse I received approval from the SMEs. Could you review and approve it?

paperclypse
paperclypse previously approved these changes Dec 4, 2023
Copy link
Contributor

@paperclypse paperclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments for you to consider.

Copy link
Contributor

@paperclypse paperclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rhetoric101 rhetoric101 merged commit 844b11c into develop Dec 6, 2023
7 of 9 checks passed
@rhetoric101 rhetoric101 deleted the rhs-insert-caveate-about-consumption branch December 6, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants