Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: attempt to convert int to string in GetString() #2

Merged
merged 1 commit into from
May 22, 2024
Merged

fix: attempt to convert int to string in GetString() #2

merged 1 commit into from
May 22, 2024

Conversation

sdewitt-newrelic
Copy link
Contributor

Fixes

  • Try to convert int to string in GetString() so that integers in the config can be used as strings

@sdewitt-newrelic sdewitt-newrelic added the bug Something isn't working label May 22, 2024
jbeveland27
jbeveland27 approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@jbeveland27 jbeveland27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's kinda gross, but works. We should swap out this config approach to be more robust.

@jbeveland27 jbeveland27 merged commit 119342f into main May 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbeveland27 jbeveland27 jbeveland27 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdewitt-newrelic @jbeveland27