Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update flash messages #397

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Update flash messages #397

wants to merge 3 commits into from

Conversation

lleger
Copy link
Member

@lleger lleger commented Aug 7, 2022 •
edited
Loading

  • Look over your code one last time.
  • Test all functionality you expect to be QA'd. Don’t forget to QA user interface changes in the browser.
  • Describe what changes this PR includes.
  • Post screenshots for design review if applicable.
  • Fill in QA Notes listing clear, ordered steps for testers.

Description

Update flash messages

  • Make them human readable by default
  • Restyle with Tailwind
  • Use gettext for strings
  • Use new Phoenix components instead of content_tag

Closes [sc-18131].

Update CSP to not include subdomain
By default, let's leave it just as the root domain, since that is what
we'll use by default. If an app needs a subdomain, it can be added in
that app specifically -- but this is a business decision, not a general
one.

Screenshots

CleanShot 2022-08-06 at 19 16 15@2x

QA Notes

PR Author Browser Info: Safari

**QA Tester Browser Info:**

## Environment Setup

- [ ] [Add necessary environment setup, e.g. whether to update dependencies, OR specify none]

## Testing Steps

- [ ] Sign up for an account or reset a password — any action to trigger a flash

## Notes

- [ ] [Tester should add any comments, questions, or concerns that pop up during QA]

lleger added 3 commits August 5, 2022 23:57
@lleger
Update Elixir and Phoenix and all deps
5d0dc9d 
Also updates generated files from new Phoenix project. I updated this
manually comparing a fresh Phoenix 1.6.11. I also used the [PhoenixDiff]
project to double check.

[phoenixdiff]: https://www.phoenixdiff.org/?source=1.5.6&target=1.6.11
@lleger
Update flash messages
35cd7e5 
- Make them human readable by default
- Restyle with Tailwind
- Use gettext for strings
- Use new Phoenix components instead of content_tag
@lleger
Update CSP to not include subdomain
dec2997 
By default, let's leave it just as the root domain, since that is what
we'll use by default. If an app needs a subdomain, it can be added in
that app specifically -- but this is a business decision, not a general
one.
@custodian custodian bot added the in-progress Work is ongoing or pending label Aug 7, 2022
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #18131: Human readable error messages by default.

@lleger
Copy link
Member Author

lleger commented Aug 7, 2022

This will need to be rebased once #395 is merged.

@lleger lleger changed the title Logan/sc 18131/human readable error messages by default Update flash messages Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
in-progress Work is ongoing or pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lleger