Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add format_timestamp helper function #396

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add format_timestamp helper function #396

wants to merge 2 commits into from

Conversation

lleger
Copy link
Member

@lleger lleger commented Aug 6, 2022 •
edited
Loading

  • Look over your code one last time.
  • Test all functionality you expect to be QA'd. Don’t forget to QA user interface changes in the browser.
  • Describe what changes this PR includes.
  • Post screenshots for design review if applicable.
  • Fill in QA Notes listing clear, ordered steps for testers.

Description

Adds format_timestamp helper function we end up using in basically every project. Stubs out some formats based on Start's design system.

Closes [sc-18133].

Screenshots

N/A

QA Notes

PR Author Browser Info: N/A

**QA Tester Browser Info:**

## Environment Setup

N/A

## Testing Steps

- [ ] Just tests — all functionality unit tested

## Notes

- [ ] [Tester should add any comments, questions, or concerns that pop up during QA]

lleger added 2 commits August 5, 2022 23:57
@lleger
Update Elixir and Phoenix and all deps
5d0dc9d 
Also updates generated files from new Phoenix project. I updated this
manually comparing a fresh Phoenix 1.6.11. I also used the [PhoenixDiff]
project to double check.

[phoenixdiff]: https://www.phoenixdiff.org/?source=1.5.6&target=1.6.11
@lleger
Add format_timestamp helper function
e2307e7 
Closes [sc-18133]
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #18133: DateTime client abstraction?.

@custodian custodian bot added the in-progress Work is ongoing or pending label Aug 6, 2022
@lleger
Copy link
Member Author

lleger commented Aug 6, 2022

This will need to be rebased once #395 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
in-progress Work is ongoing or pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lleger