Handle links to other domains in Featured Section urls #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this, if a featured section in a report was configured with a URL that pointed to an outside domain (one different from `location.origin`), the link would fail when clicked because it uses the `Link` component from react router, which we've set up to work only with relative link paths. I've changed it so that we check the link and if it's to another domain (using the pre-existing logic for checking that), and if so, we render a normal `<a>` tag that will not interact with react router at all. If it _is_ a relative link, then it will use the react router `Link` component as before.
nmorduch
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, if a featured section in a report was configured with a URL that pointed to an outside domain (one different from
location.origin), the link would fail when clicked because it uses theLinkcomponent from react router, which we've set up to work only with relative link paths.I've changed it so that we check the link and if it's to another domain (using the pre-existing logic for checking that), and if so, we render a normal
<a>tag that will not interact with react router at all. If it is a relative link, then it will use the react routerLinkcomponent as before.