Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON schema for values.yaml. #376

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

bear454
Copy link
Contributor

@bear454 bear454 commented Mar 8, 2024

... including two small consistency fixes for the values file.

Having a JSON schema allows for helm lint to validate the supplied values, both in values.yaml and via --set command line arguments.

JSON schema is set to version draft/2019-09, the newest version supported by AWS EKS Add-ons.

While there is still some work that could be done for validation, IMO this schema can be considered functionally complete:

  • all non-deprecated attributes are included;
  • types are defined as observable, including nulls as referenced in the standard values or descriptions;
  • all descriptions from the README are included;
  • formats, enumerations, and regex patterns are defined based on kubernetes and OpenShift requirements;
  • fixed attributes are set via regex pattern validation (e.g. Azure "DONOTMODIFY" attributes);
  • and of course helm lint shows 0 failures.

Additional validations are welcomed!

2 small consistency fixes for the values file.
@becitsthere becitsthere merged commit c0b417d into neuvector:master Mar 19, 2024
1 check passed
@bear454 bear454 deleted the values-schema branch April 25, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants