feat: add FeeRecipientModule and SendTipToProposer params to update fee and tip handling #NTRN-424 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joldie777
changed the title
joldie777
force-pushed
the
feat/update-fee-and-tip-handling
branch
from
e14b726 to
ca5415d
Compare
joldie777
force-pushed
the
feat/update-fee-and-tip-handling
branch
from
ca5415d to
d982e91
Compare
swelf19
reviewed
Jan 21, 2025
| ) (string, error) { | ||
| var err error | ||
|
|
||
| tipPayee := feeRecipientModule |
There was a problem hiding this comment.
In this code, the tipPayee variable takes on different formats depending on the if condition. Specifically, feeRecipientModule is a human-readable name of the module, while proposer.String() represents a Bech32 address, such as neutron1blablabla.
Currently, the return value of tipPayee is used only for broadcasting an event. However, future use cases might arise where users expect a consistent format, regardless of the params.SendTipToProposer condition. Returning two semantically different values under the same variable name can lead to confusion and potential bugs. This behavior should be fixed to ensure tipPayee always has a consistent and predictable format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: https://hadronlabs.atlassian.net/browse/NTRN-424