Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Remove GH variable dependence for tests #80

Merged
merged 2 commits into from
Mar 13, 2024
Merged

[CI] Remove GH variable dependence for tests #80

merged 2 commits into from
Mar 13, 2024

Conversation

surchs
Copy link
Contributor

@surchs surchs commented Mar 9, 2024

Instead of referring to GH variables in the test
workflows, we just hardcode the API URL in the workflow.

This is not ideal, but better than the variable - because variables are not shared with forks.

Changes proposed in this pull request:

  • replace GH variable with hardcoded API URL in the workflow
  • remove the GH variable (manual action, not part of the PR, will happen once merged)

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

Instead of referring to GH variables in the test
workflows, we just hardcode the API URL in the workflow.

This is not ideal, but better than the variable - because variables are
not shared with forks.
Copy link

netlify bot commented Mar 9, 2024

Deploy Preview for neurobagel-query ready!

Name Link
🔨 Latest commit 2e03e4a
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query/deploys/65f11d468a30640008801ad2
😎 Deploy Preview https://deploy-preview-80--neurobagel-query.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmanaem rmanaem self-requested a review March 12, 2024 22:00
@rmanaem rmanaem added the pr-internal Non-user-facing code improvement, will increment patch version when merged (0.0.+1) label Mar 12, 2024
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Feel free to merge after #83 🧑‍🍳
I think the CI prefix would be more appropriate here wdyt?

@surchs surchs changed the title [MNT] Remove GH variable dependence for tests [CI] Remove GH variable dependence for tests Mar 13, 2024
@surchs surchs merged commit 3062abc into main Mar 13, 2024
8 checks passed
@surchs surchs deleted the issue79 branch March 13, 2024 03:30
@surchs
Copy link
Contributor Author

surchs commented Apr 11, 2024

🚀 PR was released in v0.2.0 🚀

@surchs surchs added the released This issue/pull request has been released. label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-internal Non-user-facing code improvement, will increment patch version when merged (0.0.+1) released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI cannot run on PRs from forks because repo variables are not shared with forks
2 participants