Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Document NB_QUERY_HEADER_SCRIPT #468

Merged
merged 5 commits into from
Feb 2, 2025
Merged

[DOC] Document NB_QUERY_HEADER_SCRIPT #468

merged 5 commits into from
Feb 2, 2025

Conversation

surchs
Copy link
Contributor

@surchs surchs commented Jan 29, 2025

Changes proposed in this pull request:

  • short description on the new env variable for header scripts

NOTE: If this pull request is to be released, the release label must be applied once the review process is done to avoid the local and remote from going out of sync as a consequence of the bump version workflow run

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass
  • If the PR changes the participant-level and/or the dataset-level result file, the query-tool-results files in the neurobagel_examples repo have been regenerated

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

Summary by Sourcery

Documentation:

  • Document the NB_QUERY_HEADER_SCRIPT environment variable, which allows users to add custom scripts to the header of the query tool.

Copy link

sourcery-ai bot commented Jan 29, 2025

Reviewer's Guide by Sourcery

This pull request adds documentation for the NB_QUERY_HEADER_SCRIPT environment variable, which allows users to add a custom script to the header of the query tool.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Documented the NB_QUERY_HEADER_SCRIPT environment variable.
  • Added a description of the NB_QUERY_HEADER_SCRIPT environment variable to the README.
  • Provided an example of how to use the NB_QUERY_HEADER_SCRIPT environment variable.
README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@surchs surchs marked this pull request as ready for review January 29, 2025 21:47
Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for neurobagel-query ready!

Name Link
🔨 Latest commit cb56bd9
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query/deploys/679d53355b3ce00008398809
😎 Deploy Preview https://deploy-preview-468--neurobagel-query.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alyssadai alyssadai self-requested a review January 29, 2025 22:55
Copy link
Contributor

@alyssadai alyssadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @surchs for the quick fix! I left a comment about another variable ### I realized we changed the default of in #450 - not sure if want to fix that here, but since they're both README-relevant I thought I'd mention it.

See if you agree, then 🧑‍🍳

(Also, don't forget a PR label!)

@surchs surchs added the pr-documentation Change that only affects user documentation label Jan 31, 2025
@surchs surchs merged commit ab5b1ea into main Feb 2, 2025
14 checks passed
@surchs surchs deleted the expand_readme branch February 2, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-documentation Change that only affects user documentation
Projects
Status: Review - Done
Development

Successfully merging this pull request may close these issues.

2 participants