Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fixed the performance issues caused by re-rendering #39

Merged
merged 8 commits into from
Mar 1, 2024
Merged

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Feb 29, 2024

Changes proposed in this pull request:

  • Memoized ResultCard component and updateDownload call back function
  • Implemented virtualization solution for rendering the an array of ResultCard components

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for neurobagel-query ready!

Name Link
🔨 Latest commit 0438967
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query/deploys/65e11a29061d050008e4d0d2
😎 Deploy Preview https://deploy-preview-39--neurobagel-query.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmanaem rmanaem added the pr-bug-fix Bug fix, will increment patch version when merged (0.0.+1) label Feb 29, 2024
@surchs surchs self-requested a review March 1, 2024 00:28
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rmanaem, this is great! 🎉

performance wise this is 99% of the solution and the lag on select-all is completely acceptable at the moment, I think.

let's merge this 🧑‍🍳

@rmanaem rmanaem merged commit dce0493 into main Mar 1, 2024
6 checks passed
@rmanaem rmanaem deleted the bug-17 branch March 1, 2024 17:14
@surchs
Copy link
Contributor

surchs commented Mar 7, 2024

🚀 PR was released in v0.1.0 🚀

@surchs surchs added the released This issue/pull request has been released. label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bug-fix Bug fix, will increment patch version when merged (0.0.+1) released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate performance issues
2 participants