Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Added prettier support #35

Merged
merged 5 commits into from
Feb 29, 2024
Merged

[MNT] Added prettier support #35

merged 5 commits into from
Feb 29, 2024

Conversation

samadpls
Copy link
Contributor

@samadpls samadpls commented Feb 27, 2024

Changes proposed in this pull request:

  • Added support to Prettier on pre-commit

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #11
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for neurobagel-query ready!

Name Link
🔨 Latest commit 9b3ea9e
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query/deploys/65df9a2ffa3af4000822b018
😎 Deploy Preview https://deploy-preview-35--neurobagel-query.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmanaem rmanaem self-requested a review February 27, 2024 21:25
@rmanaem rmanaem added the pr-internal Non-user-facing code improvement, will increment patch version when merged (0.0.+1) label Feb 27, 2024
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @samadpls!
I think it's better to run prettier on lint-staged instead of directly running it on pre-commit. This ensures that only files/changes ready for commit will be formatted.
As for the title, may I suggest: [MNT] Configured prettier to run on lint-staged?
Let me know what you think.

@surchs surchs added the _community [BOT ONLY] PR label for community contributions. Used for tracking label Feb 27, 2024
@samadpls samadpls changed the title [ENH] Added prettier support [MNT] Added prettier support Feb 28, 2024
@samadpls samadpls requested a review from rmanaem February 28, 2024 15:27
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying the requested changes @samadpls! I believe this is good to go 🧑‍🍳

@rmanaem rmanaem merged commit f1321b2 into neurobagel:main Feb 29, 2024
4 checks passed
@surchs
Copy link
Contributor

surchs commented Mar 7, 2024

🚀 PR was released in v0.1.0 🚀

@surchs surchs added the released This issue/pull request has been released. label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_community [BOT ONLY] PR label for community contributions. Used for tracking pr-internal Non-user-facing code improvement, will increment patch version when merged (0.0.+1) released This issue/pull request has been released.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Run prettier on pre-commit
3 participants