Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Implemented "no pipelines" button #336

Merged
merged 3 commits into from
Oct 31, 2024
Merged

[FIX] Implemented "no pipelines" button #336

merged 3 commits into from
Oct 31, 2024

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Oct 31, 2024 •
edited by surchs
Loading

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@rmanaem rmanaem added the pr-patch Incremental feature improvement, will increment patch version when merged (0.0.+1) label Oct 31, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 31, 2024 •
edited
Loading

✅ Deploy Preview for neurobagel-query ready!

Name Link
🔨 Latest commit 432d910
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query/deploys/6722dfb566754e0007b587c7
😎 Deploy Preview https://deploy-preview-336--neurobagel-query.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surchs surchs self-requested a review October 31, 2024 01:59
surchs
surchs approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, looks great!

🧑‍🍳

@rmanaem rmanaem merged commit bd57b48 into main Oct 31, 2024
11 checks passed
@rmanaem rmanaem deleted the maint-334 branch October 31, 2024 14:09
@neurobagel-bot Neurobagel Bot
Copy link
Contributor

neurobagel-bot bot commented Nov 5, 2024

🚀 PR was released in v0.6.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
pr-patch Incremental feature improvement, will increment patch version when merged (0.0.+1) released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AVAILABLE PIPELINES hover on results card looks a little strange when there's no pipeline data
2 participants
@rmanaem @surchs