Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Refactored syncing of the URLSearchParams and selected nodes #25

Merged
merged 4 commits into from
Feb 19, 2024
Merged

[FIX] Refactored syncing of the URLSearchParams and selected nodes #25

merged 4 commits into from
Feb 19, 2024

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Feb 15, 2024 •
edited by surchs
Loading

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@netlify Netlify
Copy link

netlify bot commented Feb 15, 2024 •
edited
Loading

✅ Deploy Preview for neurobagel-query ready!

Name Link
🔨 Latest commit cf78ffa
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query/deploys/65d3867956cb68000936531a
😎 Deploy Preview https://deploy-preview-25--neurobagel-query.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmanaem rmanaem added the pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) label Feb 15, 2024
@ghost
Copy link

ghost commented Feb 15, 2024 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@rmanaem rmanaem added pr-bug-fix Bug fix, will increment patch version when merged (0.0.+1) and removed pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) labels Feb 15, 2024
@surchs surchs self-requested a review February 15, 2024 20:55
surchs
surchs approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thanks @rmanaem

one suggestion and then 🧑‍🍳

@rmanaem rmanaem merged commit f7a2de1 into main Feb 19, 2024
6 checks passed
@rmanaem rmanaem deleted the bug-24 branch February 19, 2024 16:51
@rmanaem rmanaem mentioned this pull request Feb 27, 2024
Closed
@surchs
Copy link
Contributor

surchs commented Mar 7, 2024

🚀 PR was released in v0.1.0 🚀

@surchs surchs added the released This issue/pull request has been released. label Mar 7, 2024
@rmanaem rmanaem changed the title [FIX] Refactored synching of the URLSearchParams and selected nodes [FIX] Refactored syncing of the URLSearchParams and selected nodes Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
pr-bug-fix Bug fix, will increment patch version when merged (0.0.+1) released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor the synching of the URLSearchParams and selected nodes
2 participants
@rmanaem @surchs