Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Explicitly check that local_nb_nodes.json is an existing file #98

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Jun 20, 2024

Changes proposed in this pull request:

  • Instead of simply checking if the path exists (which can cause problems if the path points to a directory instead of a file), check if local_nb_nodes.json is an existing file

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai added pr-bug-fix Bug fix, will increment patch version when merged (0.0.+1) release Create a release when this PR is merged labels Jun 20, 2024
@alyssadai alyssadai requested a review from rmanaem June 20, 2024 13:34
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@alyssadai alyssadai merged commit 5009068 into main Jun 20, 2024
7 checks passed
@alyssadai alyssadai deleted the bug-81/check-nodes-file branch June 20, 2024 20:09
@surchs
Copy link
Contributor

surchs commented Jun 20, 2024

🚀 PR was released in v0.2.1 🚀

@surchs surchs added the released This issue/pull request has been released. label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bug-fix Bug fix, will increment patch version when merged (0.0.+1) release Create a release when this PR is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API (sometimes) exits when local_nb_nodes.json is a directory
3 participants