Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] Set default timeout to None #94

Merged
merged 1 commit into from
Jun 12, 2024
Merged

[MNT] Set default timeout to None #94

merged 1 commit into from
Jun 12, 2024

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Jun 11, 2024 •
edited by surchs
Loading

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@rmanaem rmanaem added the pr-patch Incremental feature improvement, will increment patch version when merged (0.0.+1) label Jun 11, 2024
@rmanaem rmanaem requested a review from surchs June 11, 2024 18:14
@coveralls
Copy link
Collaborator

coveralls commented Jun 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9470714481

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.914%
Totals Coverage Status
Change from base Build 9287985610: 0.0%
Covered Lines: 471
Relevant Lines: 486
💛 - Coveralls

@surchs surchs requested review from surchs and removed request for surchs June 11, 2024 19:30
surchs
surchs approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @rmanaem, thanks!!

🧑‍🍳

I think we should release off of this PR and then redeploy our own f-API

@surchs surchs added the release Create a release when this PR is merged label Jun 11, 2024
@rmanaem rmanaem merged commit f326da8 into main Jun 12, 2024
7 checks passed
@rmanaem rmanaem deleted the maint-93 branch June 12, 2024 14:30
@surchs
Copy link
Contributor

surchs commented Jun 12, 2024

🚀 PR was released in v0.2.0 🚀

@surchs surchs added the released This issue/pull request has been released. label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
pr-patch Incremental feature improvement, will increment patch version when merged (0.0.+1) release Create a release when this PR is merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set default timeout to None
3 participants
@rmanaem @coveralls @surchs