Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement handling of subjects with BIDS data but no session layers #88

Merged
merged 7 commits into from
Feb 24, 2023

Conversation

alyssadai
Copy link
Contributor

  • Added a create_session utility function + test

Closes #82

- added function and test for create_session utility
@alyssadai alyssadai requested a review from surchs February 23, 2023 21:39
@coveralls
Copy link
Collaborator

coveralls commented Feb 23, 2023

Pull Request Test Coverage Report for Build 4257080996

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 24 of 24 (100.0%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 98.143%

Files with Coverage Reduction New Missed Lines %
bagelbids/cli.py 3 96.25%
Totals Coverage Status
Change from base Build 4247749074: -0.2%
Covered Lines: 370
Relevant Lines: 377

💛 - Coveralls

Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice @alyssadai , as discussed in the call, could you please change the create_session to something like create_acquisitions and make sure it returns a newly created list (that can be empty).

- New test added to check session labels in jsonld output
- isort pre-commit config updated to avoid conflicts with Black line length setting
@alyssadai alyssadai requested a review from surchs February 24, 2023 20:10
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this @alyssadai, all looks very good! Left some 🍒 comments, take a look, but good to go

@alyssadai alyssadai merged commit 8d664dd into main Feb 24, 2023
@alyssadai alyssadai deleted the feat-82 branch February 24, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants