-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement handling of subjects with BIDS data but no session layers #88
Conversation
- added function and test for create_session utility
Pull Request Test Coverage Report for Build 4257080996Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice @alyssadai , as discussed in the call, could you please change the create_session
to something like create_acquisitions
and make sure it returns a newly created list (that can be empty).
- New test added to check session labels in jsonld output - isort pre-commit config updated to avoid conflicts with Black line length setting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this @alyssadai, all looks very good! Left some 🍒 comments, take a look, but good to go
create_session
utility function + testCloses #82